Skip to content

Make default start_from_scratch configurable#86

Merged
raphaelsty merged 2 commits into
lightonai:mainfrom
antonchen:pr/configurable-start-from-scratch-default
May 28, 2026
Merged

Make default start_from_scratch configurable#86
raphaelsty merged 2 commits into
lightonai:mainfrom
antonchen:pr/configurable-start-from-scratch-default

Conversation

@antonchen

Copy link
Copy Markdown
Contributor

Summary

  • read the default threshold from
  • apply that runtime default consistently in the library and API index config handling
  • add focused tests for the library defaults and the API create-index path

Validation

  • cargo fmt --all -- --check
  • cargo clippy --all-targets --features "openblas" -- -D warnings
  • cargo test -p next-plaid --test start_from_scratch_env_test -- --nocapture
  • cargo test -p next-plaid-api --test start_from_scratch_env_test -- --nocapture

Implemented entirely by Codex.

@raphaelsty raphaelsty force-pushed the pr/configurable-start-from-scratch-default branch from 3817369 to 116cc51 Compare May 28, 2026 22:54
…ault

- README: new "Indexing" subsection under Environment Variables explaining
  the env var, its effect (rebuild-from-scratch threshold for new indexes),
  and that a per-index config value takes precedence.
- Dockerfile: set `ENV INDEX_DEFAULT_START_FROM_SCRATCH=999` (matching the
  built-in default) in both runtime-cpu and runtime-cuda stages so the knob
  is discoverable/overridable, plus a header comment.

Verified end-to-end: with INDEX_DEFAULT_START_FROM_SCRATCH=777, an index
created without the field persists start_from_scratch=777, while an explicit
request value (42) overrides it.
@raphaelsty raphaelsty merged commit cec3ed7 into lightonai:main May 28, 2026
20 checks passed
@raphaelsty

Copy link
Copy Markdown
Collaborator

Hi @antonchen, sorry for being late on this MR, it's merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants